fix ipykernel #799 by removing publish_status in process_control - #819
Closed
mizililo wants to merge 1 commit into
Closed
fix ipykernel #799 by removing publish_status in process_control #819mizililo wants to merge 1 commit into
mizililo wants to merge 1 commit into
Conversation
…ldn't publish execution_state
Contributor
|
I think we should wait before merging this. I have opened a JEP to move the Notice there is a on-going JEP to replace PUB socket with XPUB socket, so that clients get an iopub message upon connection and they don't have to nudge the kernel anymore. |
Author
|
OK |
Member
|
I think according to the JEPwe can close this; plus it's been 5 years, feel free to start with a new PR if this is in correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
because control_channel shouldn't publish execution_state